Skip to content

xds: ORCA to LRS propagation changes - #12203

Merged
shivaspeaks merged 12 commits into
grpc:masterfrom
shivaspeaks:lrs-custom-metric-changes
Oct 13, 2025
Merged

xds: ORCA to LRS propagation changes#12203
shivaspeaks merged 12 commits into
grpc:masterfrom
shivaspeaks:lrs-custom-metric-changes

Conversation

@shivaspeaks

@shivaspeaks shivaspeaks commented Jul 7, 2025

Copy link
Copy Markdown
Member

Implements gRFC A85 (grpc/proposal#454).

@shivaspeaks shivaspeaks changed the title ORCA to LRS propagation changes xds: ORCA to LRS propagation changes Jul 8, 2025

@ejona86 ejona86 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd have to look at some details more closely, but it is mostly just plumbing.

Comment thread xds/src/main/java/io/grpc/xds/client/LoadStatsManager2.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java
Comment thread xds/src/main/java/io/grpc/xds/BackendMetricPropagation.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/ClusterResolverLoadBalancer.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/client/LoadStatsManager2.java Outdated
@shivaspeaks
shivaspeaks requested a review from ejona86 August 4, 2025 16:54

@kannanjgithub kannanjgithub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

Comment thread xds/src/main/java/io/grpc/xds/client/LoadStatsManager2.java
Comment thread xds/src/main/java/io/grpc/xds/client/LoadStatsManager2.java Outdated
Comment thread xds/src/main/java/io/grpc/xds/client/XdsClient.java
Comment thread xds/src/main/java/io/grpc/xds/XdsClusterResource.java

@kannanjgithub kannanjgithub left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs work on unit tests.

Comment thread xds/src/main/java/io/grpc/xds/ClusterImplLoadBalancer.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/CdsLoadBalancer2Test.java
Comment thread xds/src/test/java/io/grpc/xds/ClusterResolverLoadBalancerTest.java Outdated
Comment thread xds/src/test/java/io/grpc/xds/ClusterImplLoadBalancerTest.java
Comment thread xds/src/main/java/io/grpc/xds/client/LoadStatsManager2.java
Comment thread xds/src/main/java/io/grpc/xds/client/XdsClientImpl.java Outdated
@shivaspeaks
shivaspeaks merged commit 032d292 into grpc:master Oct 13, 2025
16 of 17 checks passed
@shivaspeaks
shivaspeaks deleted the lrs-custom-metric-changes branch October 14, 2025 06:23
AgraVator pushed a commit to AgraVator/grpc-java that referenced this pull request Nov 3, 2025
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 13, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants